Re: [U-Boot] [PATCH 2/5] tools: buildman: Remove useless mkdir() in Make() in test.py

27 Oct 2019

On Sun, Oct 27, 2019 at 8:28 PM Bin Meng bmeng.cn@gmail.com wrote:
...
In the 'Make' function, the codes tries to create a directory
if current stage is 'build'. But the directory isn't used at
all anywhere.
Signed-off-by: Bin Meng bmeng.cn@gmail.com
tools/buildman/test.py | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/tools/buildman/test.py b/tools/buildman/test.py
index de02f61..0dd8516 100644
--- a/tools/buildman/test.py
+++ b/tools/buildman/test.py
@@ -22,6 +22,7 @@ import commit
 import terminal
 import test_util
 import toolchain
+from terminal import Print
Oops, this was added for debugging and should be removed ...
Will remove in v2.
...
use_network = True
@@ -156,14 +157,6 @@ class TestBuild(unittest.TestCase):
             result.return_code = commit.return_code
             result.stderr = (''.join(commit.error_list)
                 % {'basedir' : base_dir + '/.bm-work/00/'})

   if stage == 'build':


       target_dir = None


       for arg in args:


           if arg.startswith('O='):


               target_dir = arg[2:]



       if not os.path.isdir(target_dir):


           os.mkdir(target_dir)

   result.combined = result.stdout + result.stderr
   return result



--
Regards,
Bin

    