On Mon, 20 Oct 2008 15:24:53 +0200 Wolfgang Denk wd@denx.de wrote:
Dear Wolfgang Denk,
Is there another part of the patch, part 1/2, too?
Yes, but I did this part first because it's small and easily generated. Since it also affects net I wanted to get it to the custodian. The other part adds the console multiplexing and isn't directly related to this. Note this is V2 of the patch and the original version also depended on CONFIG_IO_MUX, which we decided in this ML wasn't really relevant.
In message 20081020135849.371fe4d1@ernst.jennejohn.org you wrote:
When both CONFIG_SYS_CONSOLE_IS_IN_ENV and CONFIG_NETCONSOLE are defined the user can have stdout set to nc (netconsole).
This causes problems because u-boot will try to write to nc as soon as GD_FLG_DEVINIT is set in gd->flags, which happens before the network devices are initialized in net/eth.c. This results in error messages being spewed out.
It seems this can happen only if CONFIG_SYS_CONSOLE_IS_IN_ENV is defined, right?
Correct, as I stated in the comment. Note that it isn't evident in the patch, but the console_init_r() which I changed is #ifdef CONFIG_SYS_CONSOLE_IS_IN_ENV (there's another version in the #else-branch which isn't).
To prevent this problem set GD_FLG_DEVINIT in net/eth.c:eth_initialize(), after the network devices have been initialized, instead of in common/console.c:console_init_r().
I have to admit that I don't like the idea of splitting the GD_FLG_DEVINIT into several, unrelated parts of the code.
I don't like it too much myself, but it seemed like the logical approach to me at the time I made this modification.
Would it not make more sense to have the netconsole part wait with output until it's been initialized? And/or move the netweork init to an earlier point, when netconsole is enabled?
Not a bad idea. I think it would be most logical to do it in the netconsole code, rather than moving up the network initialization.
I'll take a look at that.
--- Gary Jennejohn ********************************************************************* DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de *********************************************************************