On Fri, Feb 26, 2016 at 12:16 PM, Tom Rini trini@konsulko.com wrote:
On Thu, Feb 25, 2016 at 09:52:14AM -0600, Nishanth Menon wrote:
From: Vitaly Andrianov vitalya@ti.com
This commit replaces hard-coded EMIF and PHY DDR3 configurations for predefined SODIMMs to a calculated configuration. The SODIMM parameters are read from SODIMM's SPD and used to calculated the configuration.
The current commit supports calculation for DDR3 with 1600MHz and 1333MHz only.
Signed-off-by: Vitaly Andrianov vitalya@ti.com Signed-off-by: Lokesh Vutla lokeshvutla@ti.com Signed-off-by: Nishanth Menon nm@ti.com
[snip]
+#ifdef DUMP_DDR_CONFIG +static void dump_phy_config(struct ddr3_phy_config *ptr)
Please figure out how to do this with debug() instead.
[snip]
puts("DDR3A Speed will be configured for 1333 Operation.\n");Just printf, always, it's fine, really.
Thank you for the review. Will try to do that and repost.