Re: [U-Boot] [PATCH] HACK: fix return value of serial_assign to get printfs working again

Dear Allen Martin,

This reverts a recent change to serial_assign() that broke printfs on tegra. I don't think this is the real fix, but I'm just putting this out for others who want to test tegra patches for the other regressions.

Signed-off-by: Allen Martin amartin@nvidia.com

Indeed, NAK. Please fix iomux.c, see the comment on how serial_assign() is (mis)used there. Thanks!

---

drivers/serial/serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/serial/serial.c b/drivers/serial/serial.c index e0886d5..f1c55bf 100644 --- a/drivers/serial/serial.c +++ b/drivers/serial/serial.c @@ -268,7 +268,7 @@ int serial_assign(const char *name) return 0; }

• return -EINVAL;

• return 1;

}

/**

Best regards, Marek Vasut