On Wed, Apr 13, 2016 at 09:17:51AM -0400, Robert P. J. Day wrote:
again, in my travels, i noticed board Makefiles like, say, board/freescale/bsc9131rdb/Makefile:
ifdef MINIMAL
obj-y += spl_minimal.o tlb.o law.o
else
obj-y += bsc9131rdb.o obj-y += ddr.o obj-y += law.o obj-y += tlb.o #obj-y += bsc9131rdb_mux.o
endif
obviously(?), it's redundant to select building tlb.o and law.o in both parts of the conditional, when it could look like:
ifdef MINIMAL
obj-y += spl_minimal.o
else
obj-y += bsc9131rdb.o obj-y += ddr.o #obj-y += bsc9131rdb_mux.o
endif
obj-y += law.o obj-y += tlb.o
or even: obj-y += bsc9131rdb.o ddr.o endif
obj-y += law.o tlb.o
is it worth submitting a patch or two that cleans up that sort of thing, perhaps on a vendor-by-vendor basis? i can do that bit by bit if it's worth it.
I certainly don't object to making examples that people are likely to copy from from better. So in that regard, yes, it is.