Re: [U-Boot] Subject: [PATCH 0/2] Add ext4 filesystem support in uboot

12 Dec 2011


      Dear Uma Shankar,
In message 54ED165EF2FA426A95951C4785717091@sisodomain.com you wrote:
...
We at Samsung have implemented ext4 file system support in uboot. Please 
review the subsequent patches.
Please see  http://www.denx.de/wiki/U-Boot/CodingStyle  and
http://www.denx.de/wiki/U-Boot/Patches  for some hints how to submit
code.
Your patches have a number of Coding Style issues.  Please run them
through checkpatch:
WARNING: Avoid line continuations in quoted strings
WARNING: do not add new typedefs
WARNING: please, no spaces at the start of a line
WARNING: suspect code indent for conditional statements
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
ERROR: code indent should use tabs where possible
ERROR: trailing whitespace
ERROR: patch seems to be corrupt (line wrapped?)
etc. etc.
Themost critical problem is the white space corruption (line wrapped)
which causes that we cannot apply or test these patches.
Please clean up and resubmit usign "git send-email" to avoid such
white space corruptions.
Thanks.
Best regards,
Wolfgang Denk
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
They say, well, meybe it _is_ smelly, maybe it _is_ overcrowded, may-
be it _is_ a bit like Hell would be if they shut the  fires  off  and
stabled  a  herd  of  incontinent cows there for a year, but you must
admit that it is full of sheer, vibrant, dynamic _life_.
                                 - Terry Pratchett, _Moving Pictures_

Re: [U-Boot] Subject: [PATCH 0/2] ** Add ext4 filesystem support in uboot **

Wolfgang Denk

Re: [U-Boot] Subject: [PATCH 0/2] Add ext4 filesystem support in uboot