Re: [U-Boot] [PATCH 2/4] mx53loco: Add a comment about local print_cpuinfo method in board file

On Sun, Jun 24, 2012 at 4:55 AM, Wolfgang Denk wd@denx.de wrote:

...

+/*

• • Usually this is called too early printing a wrong information about
• • the clock. To fix it we need to provide this local method and call
• • it later in board_init.
• */

I don't like this change. It messes with the initialization sequence, which is not a good thing. Instead of shift more and more things backwards, we should fix any incorrect clock calculations here.

Right however the clock calculation is right but in regular initialization sequence this information is printed too early so Fabio has moved it here to change this ordering.

I agree it is not the best solution but a comment here makes it clear why this has been done.