Re: [v3 05/17] drivers: clk: Add clock driver for Intel N5X device

On Sun, Jun 13, 2021 at 4:49 PM Siew Chin Lim elly.siew.chin.lim@intel.com wrote:

Add clock manager driver for N5X. Provides clock initialization and get_rate functions.

Signed-off-by: Siew Chin Lim elly.siew.chin.lim@intel.com

---

v3:

• Use BIT() macro for CLKMGR_INTER_*_MASK macro

v2:

• common.h need to be included before clock_manager.h
• Remove unnecessary comment : write 1 to clear
• Remove unnecessary () in the code

---

drivers/clk/altera/Makefile | 3 +- drivers/clk/altera/clk-n5x.c | 489 ++++++++++++++++++++++++++ drivers/clk/altera/clk-n5x.h | 217 ++++++++++++ include/dt-bindings/clock/n5x-clock.h | 71 ++++ 4 files changed, 779 insertions(+), 1 deletion(-) create mode 100644 drivers/clk/altera/clk-n5x.c create mode 100644 drivers/clk/altera/clk-n5x.h create mode 100644 include/dt-bindings/clock/n5x-clock.h

Reviewed-by: Ley Foon Tan lftan.linux@gmail.com

Regards Ley Foon