Re: [U-Boot] [PATCH 08/28] SPEAr : FSMC driver support added

Dear Vipin KUMAR,

In message 1279084204-3263-9-git-send-email-vipin.kumar@st.com you wrote:

From: Vipin KUMAR vipin.kumar@st.com

Flexible static memory controller is a peripheral provided by ST, which controls the access to NAND chips along with many other memory device chips eg NOR, SRAM.

This patch adds the driver support for FSMC controller interfacing with NAND memory.

Signed-off-by: Vipin Kumar vipin.kumar@st.com

...

+static void fsmc_nand_hwcontrol(struct mtd_info *mtd, int cmd, uint ctrl) +{

• struct nand_chip *this = mtd->priv;
• ulong IO_ADDR_W;

We don't allow for CAPITAL C identifiers - these are reserved for macros.

Best regards,

Wolfgang Denk