Re: [U-Boot] [Patch] Update filesize environment variable on ubifs_load

Hi Rod,

On Saturday 18 June 2011 12:30:18 Rod Boyce wrote:

Add functionality to update filesize environment variable when ubifs_load is called to read a file from filesystem

Signed-off-by: Rod Boyce uboot@teamboyce.co.uk

------------------------------- fs/ubifs/ubifs.c

diff --git a/fs/ubifs/ubifs.c b/fs/ubifs/ubifs.c index 61f70b2..17097f2 100644 --- a/fs/ubifs/ubifs.c +++ b/fs/ubifs/ubifs.c @@ -686,6 +686,7 @@ int i; int count; int last_block_size = 0;

• char buf[32];

  c->ubi = ubi_open_volume(c->vi.ubi_num, c->vi.vol_id, UBI_READONLY); /* ubifs_findfile will resolve symlinks, so we know that we get

@@ -716,6 +717,8 @@ count = (size + UBIFS_BLOCK_SIZE - 1) >> UBIFS_BLOCK_SHIFT; printf("Loading file '%s' to addr 0x%08x with size %d (0x%08x)...\n", filename, addr, size, size);

• sprintf( buf, "%X", size );
• setenv( "filesize", buf );

Again, patch does not apply (indentation seems broken). Please see my comments in the last mail. And please don't add a space after "(" and before ")":

+ sprintf(buf, "%X", size); + setenv("filesize", buf);

Cheers, Stefan

-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de