On Thu, Dec 15, 2016 at 04:00:13PM -0200, Fabio Estevam wrote:
Simplify the 'cp' command implementation by using the memcpy() function, which brings the additional benefit of performance gain for those who have CONFIG_USE_ARCH_MEMCPY selected.
Tested on a mx6qsabreauto board where a 5x gain in performance is seen when reading 10MB from the parallel NOR memory.
Signed-off-by: Fabio Estevam fabio.estevam@nxp.com
Changes since v1:
- Always use memcpy()
I feel like this is correct. I also feel like it's too close to release to do this, so I'll be applying this shortly after release, thanks!
I also found it odd, and might try and rectify, that we don't have a 'cp' test in test.py which would make being relatively sure it's OK on x86/MIPS/PowerPC easy, slightly less easy (I'll be firing up qemu by hand and maybe writing a test too).