On Tue, May 28, 2013 at 10:31:59AM +0900, Masahiro Yamada wrote:
[snip]
So, my first request is that this commit should just import scripts as they are in Linux Kernel (plus renaming from Makefile to Makefile.kbuild)
All modification you make for U-Boot should be pushed into the next commit "Adjust Kconfig scripts for use by U-Boot".
I think this would be helpful for reviewers to track which lines are changed.
The seconde request is subject of personal preference but I like the white spaces to be kept untouched when importing files from another project.
Although I was not sure they were corrected by you, I noticed some white space errors diffs when comparing your patches with Linux Kernel makefiles. The reason is, as you mentioned in commit log, to minimise conflicts with future Kbuild updates.
Agreed on both points.