Re: [U-Boot] [PATCH v3 2/5] ARM64: rockchip: add support for rk3399 SoC based evb-board

Am 15.07.2016 um 10:42 schrieb Kever Yang:

diff --git a/board/rockchip/evb_rk3399/evb-rk3399.c b/board/rockchip/evb_rk3399/evb-rk3399.c new file mode 100644 index 0000000..357b08b --- /dev/null +++ b/board/rockchip/evb_rk3399/evb-rk3399.c @@ -0,0 +1,41 @@ +/*

• • (C) Copyright 2016 Rockchip Electronics Co., Ltd
• • SPDX-License-Identifier: GPL-2.0+
• */

+#include <dm.h> +#include <common.h> +#include <asm/armv8/mmu.h>

+DECLARE_GLOBAL_DATA_PTR;

+static struct mm_region rk3399_mem_map[] = {

• {

• .base = 0x0UL,
  

• .size = 0x80000000UL,
  

• .attrs = PTE_BLOCK_MEMTYPE(MT_NORMAL) |
  

• 	 PTE_BLOCK_INNER_SHARE
  

• }, {

• .base = 0xf0000000UL,
  

• .size = 0x10000000UL,
  

• .attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) |
  

• 	 PTE_BLOCK_NON_SHARE |
  

• 	 PTE_BLOCK_PXN | PTE_BLOCK_UXN
  

• }, {

• /* List terminator */
  

• 0,
  

• }

+};

+struct mm_region *mem_map = rk3399_mem_map;

[snip]

Why have this at board level? Wouldn't this be better kept in mach-rockchip?

Regards, Andreas