On Sat, May 11, 2013 at 11:27:41PM +0800, Sonic Zhang wrote:
Hi Tom,
On Thu, May 9, 2013 at 8:09 PM, Tom Rini trini@ti.com wrote:
Some number of these changes haven't been posted to the list for review yet. I'm pretty sure. I don't recall seeing the CONFIG_CMD_SOFTSWITCH stuff go past, and you didn't document that new flag in the top-level
I just forward the former softswtich command patch to you which include the definition of CONFIG_CMD_SOFTSWITCH. What else do you think are missing?
Well, please go over everything else and make sure it's showing up in patchwork. I spotted one trivially so I don't know how many others might have been missed.
README. Also, you did a merge of your patman branch which means there's extra stuff in your commit messages.
Because this command is only implemented for blackfin by now. Should I explan this limitation in the README as well?
Yes.
Please submit the new patches to the mailing list, and re-submit the pull request with everything else you do have ready. Thanks!
Yes, I just figured out my patman subfolder isn't equal to the upstream master, but I didn't add any stuff except for doing rebase. It looks some upstream patches may be lost during rebase. I will try to redo rebase and re-submit the pull request.
Thanks!