Hi Gaurav,
On 29.06.22 09:06, Gaurav Jain wrote:
Hi Stefano
This patch is put into state "changes requested". But it is a different patch in fsl_rsa. There is no change requested with this patch.
Something went wrong - I have applied this patch to push to 2022.07, but in CI I get the same errors I found before, that is PowerPC build was broken:
https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/457090
I hadn't time to check this, and I suppose that issue is not yet fixed and I drop the patch from MR (Layerscape is broken, too), that is V3 has not fixed CI as in V2. Or is there anothe rpatch I had to pick up ?
Best regards, Stefano
Regards Gaurav Jain
-----Original Message----- From: Stefano Babic sbabic@denx.de Sent: Wednesday, June 15, 2022 6:20 PM To: Gaurav Jain gaurav.jain@nxp.com; Fabio Estevam festevam@gmail.com Cc: U-Boot-Denx u-boot@lists.denx.de; Peng Fan peng.fan@nxp.com; dl- uboot-imx uboot-imx@nxp.com; Horia Geanta horia.geanta@nxp.com; Varun Sethi V.Sethi@nxp.com; Ye Li ye.li@nxp.com Subject: Re: [EXT] Re: [PATCH v3] crypto/fsl: fsl_rsa: Fix dcache issue in the driver
Caution: EXT Email
On 15.06.22 14:45, Gaurav Jain wrote:
Hi Fabio
-----Original Message----- From: Fabio Estevam festevam@gmail.com Sent: Wednesday, June 15, 2022 6:11 PM To: Gaurav Jain gaurav.jain@nxp.com Cc: U-Boot-Denx u-boot@lists.denx.de; Stefano Babic sbabic@denx.de; Peng Fan peng.fan@nxp.com; dl-uboot-imx uboot-imx@nxp.com; Horia Geanta horia.geanta@nxp.com; Varun Sethi V.Sethi@nxp.com; Ye Li ye.li@nxp.com Subject: [EXT] Re: [PATCH v3] crypto/fsl: fsl_rsa: Fix dcache issue in the driver
Caution: EXT Email
Hi Gaurav,
On Wed, Jun 15, 2022 at 9:35 AM Gaurav Jain gaurav.jain@nxp.com wrote:
From: Ye Li ye.li@nxp.com
issue: CAAM fails with key error when perform Modular Exponentiation using PKHA Block in CAAM
Fix: add flush and invalidate dcache for keys, signature and output decrypted data processed by CAAM.
Fixes: 34276478f7 (DM: crypto/fsl - Add Freescale rsa DM driver) Signed-off-by: Ye Li ye.li@nxp.com Reviewed-by: Gaurav Jain gaurav.jain@nxp.com Acked-by: Peng Fan peng.fan@nxp.com
Please always explain what changed in the current version of the patch.
I assume you fixed the build error found in CI, correct?
This is a different patch in fsl_rsa.c I will send a different patch for the error reported by you.
Ouch...I have misunderstood. Well, then I willwait for your patch..
Regards, Stefano
Regards Gaurav Jain