Re: [PATCH 3/5] common/spl: Drop SPL_HASH_SUPPORT in favor of SPL_HASH

On Mon, Aug 23, 2021 at 07:53:18PM -0500, Alexandru Gagniuc wrote:

Both these configs exist. Stick to using CONFIG_SPL_HASH, and drop all references to CONFIG_SPL_HASH_SUPPORT.

Signed-off-by: Alexandru Gagniuc mr.nuke.me@gmail.com

[snip]

diff --git a/common/spl/Kconfig b/common/spl/Kconfig index d69d1fa5f7..c75c8aaf08 100644 --- a/common/spl/Kconfig +++ b/common/spl/Kconfig @@ -477,16 +477,6 @@ config SPL_CRYPTO this option to build the drivers in drivers/crypto as part of an SPL build.

-config SPL_HASH_SUPPORT

• bool "Support hashing drivers"
• select SHA1
• select SHA256
• help

•  Enable hashing drivers in SPL. These drivers can be used to
  

•  accelerate secure boot processing in secure applications. Enable
  

•  this option to build system-specific drivers for hash acceleration
  

•  as part of an SPL build.
  

There's a lot more work to be done around platforms that enabled sha1/sha256 this way and confirming that it was actually unusable code. For example, (as it was where I stopped paging at in less just now) ls1043aqds_nor_ddr3 drops sha256 and md5 algorithm support, I suspect because of this hunk, but could be some other part of the series. Using buildman's --show-sizes --bloat can be really handy to see when a patch drops out a bunch of code, or adds it in.