Dear Michael Schwingen,
In message 1294062338-21084-8-git-send-email-michael@schwingen.org you wrote:
Signed-off-by: Michael Schwingen michael@schwingen.org
board/actux1/actux1.c | 22 +++++++++++--------- board/actux1/config.mk | 7 +---- board/actux1/u-boot.lds | 42 +++++++++++++++++++++++++++------------ boards.cfg | 5 +++- include/configs/actux1.h | 48 +++++++++++++++++++++++++++------------------ 5 files changed, 76 insertions(+), 48 deletions(-)
diff --git a/board/actux1/actux1.c b/board/actux1/actux1.c index 399be23..c56ec94 100644 --- a/board/actux1/actux1.c +++ b/board/actux1/actux1.c @@ -42,6 +42,17 @@
DECLARE_GLOBAL_DATA_PTR;
+int board_early_init_f (void) +{
- /* CS5: Debug port */
- *IXP425_EXP_CS5 = 0x9d520003;
- /* CS6: HwRel */
- *IXP425_EXP_CS6 = 0x81860001;
- /* CS7: LEDs */
- *IXP425_EXP_CS7 = 0x80900003;
- return 0;
Please always use I/O accessors. Please fix globally.
int dram_init (void) {
- gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
- gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
- gd->ram_size = PHYS_SDRAM_1_SIZE; return (0);
You should use get_ram_size() here.
diff --git a/board/actux1/config.mk b/board/actux1/config.mk index 88634f7..a370337 100644 --- a/board/actux1/config.mk +++ b/board/actux1/config.mk @@ -1,6 +1,3 @@ -CONFIG_SYS_TEXT_BASE = 0x00e00000
-# include NPE ethernet driver -BOARDLIBS = arch/arm/cpu/ixp/npe/libnpe.o
LDSCRIPT := $(SRCTREE)/board/$(BOARDDIR)/u-boot.lds +PLATFORM_RELFLAGS += -ffunction-sections -fdata-sections +PLATFORM_LDFLAGS += --gc-sections
Can we please get rid of this file completely?
Best regards,
Wolfgang Denk