Re: [U-Boot] [PATCH 07/11] Allow setting CONFIG_NR_DRAM_BANKS to a larger value

Dear rogan@dawes.za.net,

In message 1300435500-4909-8-git-send-email-rogan@dawes.za.net you wrote:

From: rogan@dawes.za.net rogan@dawes.za.net

This allows us to match the exact behaviour of the vendor U-boot in the kernel boot logs

Please note that the behaviour of some out of tree port is not exactly a criterion for how U-Boot should behave.

Could you please describe what exactly you consider wrong witrh the current implementation?

--- a/common/memsize.c +++ b/common/memsize.c @@ -46,6 +46,9 @@ long get_ram_size(volatile long *base, long maxsize) long size; int i = 0;

• if (base == -1)

• return 0;
  

You should never call get_ram_size() with invalid parameters in the first place.

Best regards,

Wolfgang Denk