17 Oct
2008
17 Oct
'08
11:11 p.m.
Dear Timur Tabi,
In message 1224276846-18080-1-git-send-email-timur@freescale.com you wrote:
Commit f7d190b1 corrected the value of MPC85xx_PORDEVSR2_SEC_CFG, but forgot to add a comment that the correct value disagrees with the 8544 reference manual. Without this comment, a developer looking at the code would get confused.
Hmm... The developer looking at the code is indeed confused ;-)
+/* The 8544 RM says this is bit 26, but it's really bit 28 */ #define MPC85xx_PORDEVSR2_SEC_CFG 0x00000080
But 0x00000080 is bit 24; bit 28 would be 0x00000008 - or not?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
The IQ of the group is the lowest IQ of a member of the group divided
by the number of people in the group.