On 10/03/2018 03:39 PM, Michal Simek wrote:
Hi Marek,
Hi,
[...]
diff --git a/common/spl/spl_ram.c b/common/spl/spl_ram.c index e594beaeaa..619b39a537 100644 --- a/common/spl/spl_ram.c +++ b/common/spl/spl_ram.c @@ -63,8 +63,9 @@ static int spl_ram_load_image(struct spl_image_info *spl_image, * No binman support or no information. For now, fix it * to the address pointed to by U-Boot. */
u_boot_pos = CONFIG_SYS_TEXT_BASE -sizeof(struct image_header);
header = spl_get_load_buffer(-sizeof(*header),sizeof(*header));I am curious how you have tested this change. Because I see on my zc706 that this breaks my SPL boot flow.
Definitely not on every single board we support ...
This should be assigned to u_boot_pos instead of header (which is done 2 line below) and also here is additional empty line which shouldn't be there.
Patches welcome. And yes, it should be u_boot_pos .