Dear Prafulla,
In message 73173D32E9439E4ABB5151606C3E19E201CF9E64AE@SC-VEXCH1.marvell.com you wrote:
...
+#define KW_EGIGA0_BASE (KW_REGISTER(0x72000)) +#define KW_EGIGA1_BASE (KW_REGISTER(0x76000))
Use a C struct?
These are the Base address referred by register structures.
I am aware of this.
Generally this type of declaration used for other cpu/socs.
Well, "generally" is a weak argument - you find examples for both. Coming from the PowerPC world, and haveing been using the code these sinde > 10 years, I'm more accustomed to see something like a big IMMR sturcture here.
I have almost done with other changes except this one Do this really need to be converted C struct?
No, you do not *have* to. That's why I asked it as a question. If I had to write the code, I would use a C struct, and I think it would be easier to read.
But I don't insist on such a change. You can find arguments for both solutions, so decide what deems best for you.
I will have to put some efforts to get it done :-(.
Well, changing it would actually be trivial. But as mentioned above: I don't insist. It's largely a matter of taste, I think.
Best regards,
Wolfgang Denk