Hello Joakim,
Joakim Tjernlund wrote:
Heiko Schocher heiko.schocher@invitel.hu wrote on 23/09/2009 11:02:09:
Hello Joakim,
Joakim Tjernlund wrote:
Dear Joakim Tjernlund,
In message <1253178437-32398-1-git-send-email-
Joakim.Tjernlund@transmode.se> you wrote:
After issuing a STOP one must wait until the STOP has completed on the bus before doing something new to the controller.
Also add an extra read of SR as the manual mentions doing that is a good idea.
Remove surplus write of CR just before a write, isn't required and could potentially disturb the I2C bus.
Signed-off-by: Joakim Tjernlund Joakim.Tjernlund@transmode.se
drivers/i2c/fsl_i2c.c | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-)
Could you _please_ start adding some version information to your patches, and a list of changes between the versions?
Thanks.
Yes, that was a bit sloppy on my part, sorry. What do you want me to do now? Resend the whole series or do I get away with it this time? All but the last patch is in u-boot-i2c testing(by Heiko) repo already.
You mean with last patch, this patch:?
http://lists.denx.de/pipermail/u-boot/2009-September/061187.html
Yes, that is the last one. I don't see it in testing though.
applied to u-boot-i2c testing
I also think that fsl_i2c: Wait for STOP condition to propagate, fsl_i2c: Add CONFIG_FSL_I2C_CUSTOM_{DFSR/FDR} and fsl_i2c: Wait for STOP condition to propagate can go to WD
The fsl_i2c: Impl. AN2919, rev 5 to calculate FDR/DFSR can wait a bit longer to get some more testing if you think it is needed.
I wait for the end of the week (I hope, I find time to make some tests too), and send a pull request on monday to Wolfgang.
bye Heiko