Hi Rayagonda,
On Thu, 30 Apr 2020 at 05:03, Rayagonda Kokatanur rayagonda.kokatanur@broadcom.com wrote:
Hi Simon,
On Wed, Apr 29, 2020 at 11:34 PM Simon Glass sjg@chromium.org wrote:
Hi Rayagonda,
+Stephen Warren
On Wed, 29 Apr 2020 at 10:36, Rayagonda Kokatanur rayagonda.kokatanur@broadcom.com wrote:
Add pinctrl_ops->request api to configure pctrl pad register in gpio mode.
Signed-off-by: Rayagonda Kokatanur rayagonda.kokatanur@broadcom.com
drivers/pinctrl/pinctrl-single.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)
This should use the Kconfig also (and needs a test)
Please elaborate "need a test". Do you mean a testing procedure as part of the commit message ?
No I mean U-Boot has automated tests. So when we add code we need to add tests for that code. See test/dm/rtc.c for an example. You can run them with:
make qcheck
or a single one with:
I feel we don't need the Kconfig option, looking at Linux pinctrl-single driver. Please let me know.
OK we can go without one. It is easy to add later if needed.
Regards, Simon