-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 10/03/12 13:40, Simon Glass wrote:
Hi Tom,
On Wed, Oct 3, 2012 at 1:04 PM, Tom Rini trini@ti.com wrote: On 10/03/12 12:53, Simon Glass wrote:
On x86 machines gd is unfortunately a #define, so we should avoid using gd for anything. This patch changes uses of gd to bgd so that ext4fs can be used on x86.
Signed-off-by: Simon Glass sjg@chromium.org
Is there any way to change x86 to not be using a #define for gd?
I wasn't brave enough to look hard at that, although Graeme is on copy and will know. It is actually using inline assembly to access this special variable.
Yeah, I took a quick stab at it myself earlier and didn't make it work. We need to fix this for the release. My concern was "we must share this with the kernel" but, we don't (I realized as I was drafting this reply). So I'm more OK with taking the change now than I was at first, but if we can not #define gd that will help prevent the problem from popping up in the future.
- -- Tom