Re: [PATCHv2] net: uclass: Save ethernet MAC address when generated

Dear Tom,

In message 20211120155358.376540-1-trini@konsulko.com you wrote:

When MAC address is randomly generated it should be also saved to variables. This step is there when MAC address is passed via pdata but not when it is randomly generated.

"saved to variables" ? Which variables? In C code? In the environment?

This is not clear here.

 Selecting this will allow the Ethernet interface to function

•  even when the ethaddr variable for that interface is unset.
  

•  A new MAC address will be generated on every boot and it will
  

•  not be added to the environment.
  

•  even when the ethaddr variable for that interface is unset by
  

•  generating a new MAC address in the locally administered address
  

•  space and setting the appropriate environment variable.
  

Same here: "ethaddr variable" - I guess this refers to the environment variable? Then we should write that.

Hmmm: "when the ethaddr variable ... is unset by generating ... and setting the appropriate environment variable." this is misleading, as the "ethaddr variable" is not unset by setting the env var.

Suggestion:

Selecting this will allow the Ethernet interface to function even when the ethaddr variable for that interface is unset. In this case, a random MAC address in the locally administered address space is generated. It will be saved to the appropriate environment variable, too.

Best regards,

Wolfgang Denk