On Mon, Jul 23, 2012 at 11:56:00AM -0700, Tom Rini wrote:
On Sun, Jul 08, 2012 at 10:55:16PM +0200, Wolfgang Denk wrote:
Dear Kim Phillips,
In message 20120703174156.a1082309c2b205216606a004@freescale.com you wrote:
This warning was introduced in 436da3c "ext2load: increase read speed":
ext2fs.c: In function 'ext2fs_read_file': ext2fs.c:458:19: warning: 'blocknxt' may be used uninitialized in this func= tion [-Wuninitialized]
this change makes it go away.
Cc: Eric Nelson eric.nelson@boundarydevices.com Cc: Thierry Reding thierry.reding@avionic-design.de Cc: Jason Cooper u-boot@lakedaemon.net Cc: Andreas Bie=DFmann andreas.devel@googlemail.com Cc: Reinhard Arlt reinhard.arlt@esd-electronics.com Signed-off-by: Kim Phillips kim.phillips@freescale.com
v2: changed to Thierry's recommendation in:
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/134043
build-tested only - please ack
fs/ext2/ext2fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
This doesn't fix the warning for ELDK 4.2 toolchains (gcc 4.2.2): ext2fs.c: In function 'ext2fs_read_file': ext2fs.c:443: warning: 'blocknxt' may be used uninitialized in this function
I've seen older toolchains fail a lot at detecting situations like this. I think starting with 4.5 things got a lot better.
Thierry