On 07/02/2013 02:35 PM, Tom Rini wrote:
On 07/02/2013 06:49 AM, Andreas Bießmann wrote:
Hi all,
On 06/28/2013 11:41 PM, Simon Glass wrote:
Hi Tom,
On Fri, Jun 28, 2013 at 1:25 PM, Tom Rini trini@ti.com wrote:
<snip>
@@ -660,34 +680,25 @@ static int do_bootm_states(cmd_tbl_t *cmdtp, int flag, int argc, } #endif /* Now run the OS! We hope this doesn't return */ - if (!ret && (states & BOOTM_STATE_OS_GO)) + if (!ret && (states & BOOTM_STATE_OS_GO)) { ret = boot_selected_os(argc, argv, BOOTM_STATE_OS_GO, images, boot_fn, &iflag); + if (ret) + goto err; + } + + return ret;
Thanks for getting to the bottom of this.
Just a question here - should this fall through to display the error with the code below? For example if the subcommand is not supported...
as pointed out by Simon the error message 'subcommand not supported' disappears with this patch.
<snip>
Who will fix that? I'll have a look for the avr32 specific part.
The patch I posted yesterday should fix that.
Oups, overseen, you mean http://patchwork.ozlabs.org/patch/256125/ right?
Best regards
Andreas Bießmann