Re: [U-Boot] [RFC PATCH 2/2] i.MX28: use a clear name for DDR2 initialization

On Tue, Jul 17, 2012 at 9:41 AM, Stefano Babic sbabic@denx.de wrote:

...

Agreed; I will check my current work in progress code and rework it this way. However this prefix change is highly desired as it is callmed m28 (looking as m28evk specific) instead of mx28.

Yes, mx28 is a better name - if a prefix, it should be a SOC prefix, not a board name.

But I noted : -uint32_t dram_vals[] = { +uint32_t mx28_dram_vals[] = { 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000,

why is this structure not static ?

Indeed; I will send a new patch for it.