6 Nov
2012
6 Nov
'12
8:24 a.m.
Dear Angelo,
In message 20121105211017.GA24778@angel3 you wrote:
#define VALUE (0)
you said to fix it globally, without parens.
True.
Working for the fixes i found several "accepted" files (i.e. m5282.h) full of
#define XYZ1 (1) #define XYZ2 (2)
You will find many examples of poor code. If you have time and resources, patches to clean up such are welcome.
In any case, we should not use such bad examples as excuse to add more bad code.
CodingStyle says parens around expressions must be used, but don't seems to set any rule for this case.
A simple value is not an expression that needs parens.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Sometimes a man will tell his bartender things he'll never tell his doctor.
-- Dr. Phillip Boyce, "The Menagerie" ("The Cage"),
stardate unknown.