On Tuesday 27 October 2009 15:34:10 Scott Wood wrote:
On Mon, Oct 26, 2009 at 07:57:50PM -0400, Mike Frysinger wrote:
perhaps it would make more sense to create a HOSTCOMPILE/HOSTLINK (or whatever) variable so this kind of thing isnt missed ? HOSTCOMPILE = $(HOSTCC) $(HOSTCFLAGS) HOSTLINK = $(HOSTCOMPILE) $(HOSTLDFLAGS)
Maybe. What about PEDCFLAGS? Should that be the default for HOSTCOMPILE, and then have a HOSTCOMPILENOPED?
i think the intention was to build everything with -pedantic. so add it to the default flags and drop the distinction completely. it'd make the resulting build code a lot simpler.
It restores easylogo to using the host compiler, which was broken by commit 38d299c2db81bd889c601b5dfc12c4e83ef83333 (if this was an intentional change, please let me know -- but it seems to be a build tool).
it was intentional, but for different reasons. easylogo isnt integrated into the u-boot build system, so in order to compile things in there, you had to go into the subdir and manually run `make`. if it were integrated into the build system like all other tools, then converting to host tools is fine. but unless i missed something, it doesnt appear to be ? and now, going into the subdir and running `make` wont work either ...
I was expecting it to be built by adding easylogo to TOOLSUBDIRS (it would be better if there were a distinct make target for it, but that's another patch). Other tools such as gdb already assume they're being run in this manner.
where does TOOLSUBDIRS get changed ? i dont see any place in u-boot where it is set and your patch doesnt change that from what i can see. -mike