On Thu, 16 May 2019 10:34:38 +0800 Icenowy Zheng icenowy@aosc.io wrote:
Hi Icenowy,
thanks for having a look!
于 2019年5月16日 GMT+08:00 上午9:26:29, Andre Przywara andre.przywara@arm.com 写到:
The Allwinner H6 pin controller is not really special, at least not when it comes to normal GPIO operation.
Add the H6 compatible strings to the list of recognised strings, to make GPIOs work for H6 boards.
Signed-off-by: Andre Przywara andre.przywara@arm.com
drivers/gpio/sunxi_gpio.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/gpio/sunxi_gpio.c b/drivers/gpio/sunxi_gpio.c index cbed8d42b7..780c39962a 100644 --- a/drivers/gpio/sunxi_gpio.c +++ b/drivers/gpio/sunxi_gpio.c @@ -354,12 +354,14 @@ static const struct udevice_id sunxi_gpio_ids[] = { ID("allwinner,sun8i-v3s-pinctrl", a_all), ID("allwinner,sun9i-a80-pinctrl", a_all), ID("allwinner,sun50i-a64-pinctrl", a_all),
- ID("allwinner,sun50i-h6-pinctrl", a_all), ID("allwinner,sun6i-a31-r-pinctrl", l_2), ID("allwinner,sun8i-a23-r-pinctrl", l_1), ID("allwinner,sun8i-a83t-r-pinctrl", l_1), ID("allwinner,sun8i-h3-r-pinctrl", l_1), ID("allwinner,sun9i-a80-r-pinctrl", l_3), ID("allwinner,sun50i-a64-r-pinctrl", l_1),
- ID("allwinner,sun50i-h6-r-pinctrl", l_1),
Should be l_2 because H6 has PM bank.
Oh, indeed, I totally missed that. Thanks for pointing this out!
Cheers, Andre