Hi Simon,
On Tue, Jan 22, 2019 at 9:14 AM Simon Glass sjg@chromium.org wrote:
This uclass currently has no tests. Add a sandbox driver and some simple tests to provide basic coverage.
Signed-off-by: Simon Glass sjg@chromium.org
arch/sandbox/dts/test.dts | 4 ++ arch/sandbox/include/asm/test.h | 8 ++++ drivers/pch/Makefile | 1 + drivers/pch/sandbox_pch.c | 69 +++++++++++++++++++++++++++++++++ test/dm/Makefile | 1 + test/dm/pch.c | 36 +++++++++++++++++ 6 files changed, 119 insertions(+) create mode 100644 drivers/pch/sandbox_pch.c create mode 100644 test/dm/pch.c
diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts index 1d011ded7c..9144430cc0 100644 --- a/arch/sandbox/dts/test.dts +++ b/arch/sandbox/dts/test.dts @@ -407,6 +407,10 @@ compatible = "sandbox,mmc"; };
pch {compatible = "u-boot,sandbox-pch";
Shouldn't this be "sandbox,pch", to be in consistent with others like "sandbox,mmc", "sandbox,pci"?
};pci0: pci-controller0 { compatible = "sandbox,pci"; device_type = "pci";
Other than that, Reviewed-by: Bin Meng bmeng.cn@gmail.com
Regards, Bin