Re: [U-Boot] [PATCH] Adding support for DevKit8000

Dear Dirk Behme,

In message 4A897571.9090404@googlemail.com you wrote:

Wolfgang commented already most of the topics.

:-)

So, only one comment left for me:

But a well spottet one, thanks!

...

• /* Use OMAP DIE_ID as MAC address */
• if (!eth_getenv_enetaddr("ethaddr", enetaddr)) {

• enetaddr[0] = 0x02; /* locally administered */
  

• enetaddr[1] = readl(&id_base->die_id_1) & 0xff;
  

• *(u32*)&enetaddr[2] = readl(&id_base->die_id_0);
  

Who guarantess that &enetaddr[2] will be 32 bit aligned? And hat does this machine do on unaligned accesses?

Frederik: Please fix this.

...

• eth_setenv_enetaddr("ethaddr", enetaddr);
  

• }

With the OMAP DIE_ID thread we know what you are doing here. But do we want to have this really in mainline? It looks to me like a workaround for broken hardware (that is, having no proper MAC address configured)? Or do I miss anything?

Indeed. It's fishy at best.

Best regards,

Wolfgang Denk