Hi Tom/Kamil,
Can you please apply this patch.
Cheers, Vikas
-----Original Message----- From: Vikas MANOCHA Sent: Wednesday, January 27, 2016 2:58 PM To: 'Simon Glass' Cc: Albert ARIBAUD; Kamil Lulko; U-Boot Mailing List; Peter Griffin; Antonio Borneo; rev13@wp.pl; kunhuahuang Subject: RE: [PATCH] serial: serial_stm32: move clock config from driver to board
Hi Simon,
-----Original Message----- From: sjg@google.com [mailto:sjg@google.com] On Behalf Of Simon Glass Sent: Wednesday, January 27, 2016 2:54 PM To: Vikas MANOCHA Cc: Albert ARIBAUD; Kamil Lulko; U-Boot Mailing List; Peter Griffin; Antonio Borneo; rev13@wp.pl; kunhuahuang Subject: Re: [PATCH] serial: serial_stm32: move clock config from driver to board
On 26 January 2016 at 19:12, Vikas Manocha vikas.manocha@st.com wrote:
This patch removes the uart clock enable from serial driver & move it in the board code.
Signed-off-by: Vikas Manocha vikas.manocha@st.com
arch/arm/include/asm/arch-stm32f4/stm32_defs.h | 15 ++++++++ arch/arm/include/asm/arch-stm32f4/stm32_periph.h | 27
+++++++++++++++
arch/arm/mach-stm32/stm32f4/clock.c | 20 +++++++++++ board/st/stm32f429-discovery/stm32f429-discovery.c | 3 ++ drivers/serial/serial_stm32.c | 40 ---------------------- 5 files changed, 65 insertions(+), 40 deletions(-) create mode 100644 arch/arm/include/asm/arch-stm32f4/stm32_defs.h create mode 100644 arch/arm/include/asm/arch-
stm32f4/stm32_periph.h
Reviewed-by: Simon Glass sjg@chromium.org
Thanks for reviewing.
You might consider adding a clock driver.
Yes, I agree. After some cleanup, I am planning to add support for clock and pinmux driver.
Rgds, Vikas
- Simon