On Mon, Jun 18, 2018 at 11:45:23AM +0530, Jagan Teki wrote:
On Mon, Jun 18, 2018 at 6:44 AM, Marek Vasut marex@denx.de wrote:
On 06/17/2018 06:13 PM, Vasily Khoruzhick wrote:
ohci-hcd casts priv_data pointer to (ohci_t *), thus it must be the first member in private data struct.
Fixes 831cc98b1 ("usb: sunxi: Simplify ccm reg base code")
Signed-off-by: Vasily Khoruzhick anarsoul@gmail.com
Sigh, I really wonder how (or if at all!) the original series was tested. And then I get flak for scrutinizing patches, right ...
APAIK, I did basic sanity with possible tests.
But one thing for sure is, you should have to wait for sometime to apply this patch. Applying fast (that to during weekend) making reviewers or maintainers not giving enough room to work.
It is a custodian's job to pick up what they see as obviously correct and/or important fixes ASAP. While things are working in your test cases, there are clearly other hardware combinations that are not working and that this corrects.