5 Sep
2010
5 Sep
'10
9:33 p.m.
Hi Sergei,
Le 05/09/2010 12:54, Sergei Shtylyov a écrit :
- /* Set control IPM to 3 (no low power) and DET to 1 (initialize) */
control = readl(&port->scontrol); control = (control & ~MVSATA_SCONTROL_MASK) | MVSATA_PORT_INIT;
- /* Toggle control DET back to 0 (normal operation) */
But you haven't set it to 1 yet. Maybe the comment is misplaced?
Look at the comment above, which said DET was set to 1, and at MVSATA_PORT_INIT, which combines IPM=3 and DET=1.
- return (tout? 0: 1);
Why not !tout? (And you forgot a space before colon. :-)
Why not indeed? I'll fix this in the next version.
WBR, Sergei
Thanks!
Amicalement,
--
Albert.