Hi Marek, hi Prafulla,
On 07/20/2012 01:40 PM, Marek Vasut wrote:
Dear Prafulla Wadaskar,
[...]
diff --git a/arch/arm/cpu/arm926ejs/kirkwood/dram.c b/arch/arm/cpu/arm926ejs/kirkwood/dram.c index 181b3e7..d938578 100644 --- a/arch/arm/cpu/arm926ejs/kirkwood/dram.c +++ b/arch/arm/cpu/arm926ejs/kirkwood/dram.c @@ -32,6 +32,12 @@ DECLARE_GLOBAL_DATA_PTR;
#define KW_REG_CPUCS_WIN_BAR(x) (KW_REGISTER(0x1500) + (x *
0x08))
#define KW_REG_CPUCS_WIN_SZ(x) (KW_REGISTER(0x1504) + (x *
0x08))
Hi Gerlando I have a full ack for this patch. But I would like to ask you- Since dram.c is going through this change and macros are being used in stead of c-struct for DRAM register variables. This is being one of the todo item pending from long time.
Would you like to convert macros to c-struct definition in this file?
Certainly, but let's get this applied first.
[...]
I have done a v3 version of this patchserie with Prafullas inputs. Gerlando is not in these days.
I'll send the updates soon... I have already tested them on km_kirkwood.
Regards Holger