On 05/09/2013 11:37 PM, Scott Wood wrote:
On 05/06/2013 11:53:52 AM, Michal Simek wrote:
Hi guys,
Zynq supports 8 and 16bit ONFI nand flashes. We can count number of connected pins and from that we know if 8bit or 16bit nand flash is used.
I have looked at the code and contains ONFI detection with correct detection of bus width + checking later. Why also not setup proper chip->options for NAND_BUSWIDTH_16?
Not sure how others but if driver expect just ONFI devices and support 8 and 16bit options why not just to setup chip options based on information from ONFI or not check that (busw != (chip->options & NAND_BUSWIDTH_16)) for onfi case.
This is fixed in current Linux, with NAND_BUSWIDTH_AUTO.
There was a patchset to merge in recent Linux MTD code a while back, but an expected respin didn't come. I'll try to fix it up when I process this merge window's patches.
Ok. Nice. That will be really helpful.
Thanks, Michal