On Thu, Oct 10, 2019 at 10:09 AM Anatolij Gustschin agust@denx.de wrote:
On Thu, 10 Oct 2019 09:16:14 +0200 Simon Goldschmidt simon.k.r.goldschmidt@gmail.com wrote:
On Thu, Oct 10, 2019 at 8:20 AM Ley Foon Tan ley.foon.tan@intel.com wrote:
Convert system manager for Gen5, Arria 10 and Stratix 10 from struct to defines.
Same as 2/4: please add a description about the "read address from dts" thing.
Why is this required? In the past we have rejected all new code adding defines instead of structs for register accesses. Have we changed our mind now?
Who is we? I haven't noticed that in the last 2 years. Plus Linux is rather using structs than defines, or am I wrong?
This started because Ley introduced a new platform where the structs were nearly the same but *some* registers have changed. Adding new structs that were nearly the same seemed more mess than using the same defines.
I'm not pressing this into any direction, we can continue using structs if that's the consensus.
Regards, Simon
-- Anatolij