Re: [PATCH 03/15] net-lwip: add DHCP support and dhcp commmand

On Wed, May 22, 2024 at 06:00:03PM +0200, Jerome Forissier wrote:

Add what it takes to enable CONFIG_NETDEVICES with CONFIG_NET_LWIP and enable DHCP as well as the dhcp command (CONFIG_CMD_DHCP_LWIP).

• net-lwip/net-lwip.c is mostly empty for now. It will provide functions

similar to net/net.c except based on the lwIP stack

• include/net-lwip.h is a replacement for include/net.h which is unused

when CONFIG_NET_LWIP is enabled. Declarations from the latter will be transferred to the former as needed when new network commands are ported on top of lwIP.

• CONFIG_CMD_TFTPBOOT_LWIP is introduced due to CONFIG_BOOTMETH_EFI having

an implicit dependency on do_tftpb().

Signed-off-by: Jerome Forissier jerome.forissier@linaro.org

I don't like a new symbol for re-implementing each command. To me, the user should pick lwIP or traditional stack, and CMD_DHCP gives the DHCP command and so forth, and so the Makefile gets reworked as needed.