On Tue, 2008-01-15 at 16:59, Grant Likely wrote:
Nit: Don't do it this way; do this instead (to match the style used in other Makefiles):
+COBJS-y := pq-mds-pib.o +COBJS-${CONFIG_ID_EEPROM} += sys_eeprom.o +COBJS-${CONFIG_FSL_DIU_FB} += fsl_diu_fb.o fsl_logo_bmp.o +COBJS-${CONFIG_FSL_PIXIS} += pixis.o
-SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) +SRCS := $(SOBJS:.o=.S) $(COBJS-y:.o=.c)
So, are you going to submit a patch to convert them all to be like that then?
I looked at this one in drivers/net:
COBJS-y += tsec.o COBJS-y += tsi108_eth.o COBJS-y += uli526x.o
COBJS := $(COBJS-y) SRCS := $(COBJS:.o=.c) OBJS := $(addprefix $(obj),$(COBJS))
which clearly left COBJS around and set it up based on COBJS-y contents. So I guess my question boils down to "future intent" here. Should all the files end up on COBJS or on COBJS-y really?
Thanks, jdl