Dear Daniel Gorsulowski,
In message 1238145854513-git-send-email-Daniel.Gorsulowski@esd.eu you wrote:
--===============0533980373==
This patch adds support for MEESC board from esd gmbh. The MEESC is based on an Atmel AT91SAM9263 SoC.
Signed-off-by: Daniel Gorsulowski Daniel.Gorsulowski@esd.eu
...
diff --git a/board/esd/meesc/meesc.c b/board/esd/meesc/meesc.c new file mode 100644 index 0000000..122707a --- /dev/null +++ b/board/esd/meesc/meesc.c
...
- at91_sys_write(AT91_SMC1_CYCLE(0),
AT91_SMC_NWECYCLE_(10) | AT91_SMC_NRDCYCLE_(5));- /* Configure behavior at external wait signal, byte-select mode, 16 bit
- data bus width, none data float wait states and TDF optimization */
at91_sys_write(AT91_SMC1_MODE(0),AT91_SMC_READMODE |AT91_SMC_EXNWMODE_READY |AT91_SMC_BAT_SELECT |AT91_SMC_DBW_16 |AT91_SMC_TDF_(0) |AT91_SMC_TDFMODE);
Indentation wrong.
...
+int dram_init(void) +{
- gd->bd->bi_dram[0].start = PHYS_SDRAM;
- gd->bd->bi_dram[0].size = PHYS_SDRAM_SIZE;
- return(0);
+}
Auto-sizing?
..
+/*
- LED-functions
- */
+int do_led_1a(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) +{
- return(set_gpio(argc, argv, LED1A));
+} +U_BOOT_CMD(
- led_1a, 2, 1, do_led_1a,
- "switch LED1A on or off",
- "\n"
+);
+int do_led_1b(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) +{
- return(set_gpio(argc, argv, LED1B));
+} +U_BOOT_CMD(
- led_1b, 2, 1, do_led_1b,
- "switch LED1B on or off",
- "\n"
+);
Do we really, really need new, nonstandard LED commands?
Best regards,
Wolfgang Denk