On Tue, Jan 28, 2020 at 10:33 AM Fabio Estevam festevam@gmail.com wrote:
Hi Joe,
Ping
On Mon, Jan 6, 2020 at 8:32 PM Fabio Estevam festevam@gmail.com wrote:
Hi Joe,
On Wed, Dec 11, 2019 at 8:54 AM Schrempf Frieder frieder.schrempf@kontron.de wrote:
On 11.10.19 01:00, Soeren Moch wrote:
Using a MAC address from ROM storage is the normal case for most ethernet hardware. Why should we warn about this?
Signed-off-by: Soeren Moch smoch@web.de
Some months ago I came up with the very same patch and I currently have it in my local fork with the description "Reading the MAC address from ROM is often a standard use case and should not produce a warning".
Therefore I'm supporting Soeren's and Fabio's point of view here and I'm in favor of merging this patch or if preferred, change the printf() to debug().
Reviewed-by: Frieder Schrempf frieder.schrempf@kontron.de
Any feedback, please?
Traditionally the env was the source of truth for the MAC, so using the ROM was a fall-back if the env didn't have one. But times change, I guess. I'll pull this into my next PR.
Acked-by: Joe Hershberger joe.hershberger@ni.com