On Sat, 2011-01-22 at 23:12 +0100, Wolfgang Denk wrote:
You should not undo a previous copyright. I guess you mean:
Copyright 2009-2010 Freescale Semiconductor, Inc.
?
Yes. Sorry about it.
+DECLARE_GLOBAL_DATA_PTR;
Please move this up to top of file.
OK.
+unsigned long get_tbclk(void) +{ +#ifdef CONFIG_FSL_CORENET
- return (gd->bus_clk + 8) / 16;
+#else
- return (gd->bus_clk + 4UL)/8UL;
+#endif
This looks inconsistent. Either this should be "... +8UL) / 16UL" or "... + 4) / 8;"
This part was copied from arch/powerpc/cpu/mpc85xx/cpu.c, just want too reduce the image size without including that file(cpu.c). Will fix it.
-#ifndef CONFIG_NAND_SPL +#if !defined(CONFIG_NAND_SPL) && !defined(CONFIG_TPL_BOOT) GOT_ENTRY(_start) GOT_ENTRY(_start_of_vectors) GOT_ENTRY(_end_of_vectors) GOT_ENTRY(transfer_to_handler) -#endif +#endif /* !CONFIG_TPL_BOOT || !CONFIG_NAND_SPL*/
Should that be
#endif /* !CONFIG_TPL_BOOT && !CONFIG_NAND_SPL*/
instead?
Yes. Thanks for pointing out.
And can we please make this consistent, i. e. as you do in the following:
+#endif /* !CONFIG_NAND_SPL && !CONFIG_TPL_BOOT */
OK.
Thanks.
Haiying