Hello,
Thanks for having a look!
Here are my findings:
- FEC ethernet doesn't work
- distroboot doesn't work
Did you expirience the same?
I have not tested Ethernet ports on u-boot yet. I removed distroboot support as you proposed later in the review.
Note that my evaluation board has a hardware issue on the eMMC module. I am testing this patch my flashing the bootloader on the SD card using the commands in the proposed documentation, and booting on the SD card.
Can you rework you commit msg + title please?
Done.
Can you rename to match other?
Sure.
Can you add:
&wdog3 { bootph-all; bootph-pre-ram; };
here to also enable WDT in SPL, please.
OK.
I don't think this is necessary?
You are using CONFIG_DM_SERIAL.
It is not necessary indeed.
IMHO I would disable distroboot and sync with downstream.
Done.
I synced the configuration and environment files to be closer to the downstream versions.
I will send a v3 soon.
Thanks,
Mathieu