Re: [U-Boot] [PATCH 1/2] Add run_command_list() to run a list of commands

Dear Simon Glass,

In message 1329286030-32560-1-git-send-email-sjg@chromium.org you wrote:

This new function runs a list of commands separated by semicolon. We move this out of cmd_source so that it can be used by other code. The PXE also uses the new function.

Separated by semicolon? What about newline here?

• printf("running: %s\n", localcmd);

Should this be a debug() ?

• line = next = cmd;
• while (*next) {

• if (*next == '\n') {
  

• 	*next = '\0';
  

• 	/* run only non-empty commands */
  

• 	if (*line) {
  

• 		debug("** exec: \"%s\"\n", line);
  

• 		if (builtin_run_command(line, 0) < 0) {
  

• 			rcode = 1;
  

• 			break;
  

• 		}
  

• 	}
  

• 	line = next + 1;
  

• }
  

• ++next;
  

• }
• if (rcode == 0 && *cmd)

• rcode = (builtin_run_command(cmd, 0) >= 0);
  

This looks wrong to me. There you are re-executing the original command. Shoudl this not be

if (rcode == 0 && *line) rcode = (run_command(line, 0) >= 0);

??

Best regards,

Wolfgang Denk