Re: [PATCH] sandbox: net: lwip: use EOPNOTSUPP not ENOTSUPP

On Tue, 5 Nov 2024 at 12:25, Jerome Forissier jerome.forissier@linaro.org wrote:

EOPNOTSUPP is the recommended SUSV4 error code that should be used instead of ENOTSUPP.

Signed-off-by: Jerome Forissier jerome.forissier@linaro.org

drivers/net/sandbox-lwip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/sandbox-lwip.c b/drivers/net/sandbox-lwip.c index 3721033c310..5c9a0cb1b9f 100644 --- a/drivers/net/sandbox-lwip.c +++ b/drivers/net/sandbox-lwip.c @@ -27,7 +27,7 @@ static int sb_lwip_eth_send(struct udevice *dev, void *packet, int length) { debug("eth_sandbox_lwip: Send packet %d\n", length);

•   return -ENOTSUPP;
  

•   return -EOPNOTSUPP;
  

I think we are fine without this. Isn't EOPNOTSUPP for socket use only?

Thanks /Ilias

}

static int sb_lwip_eth_recv(struct udevice *dev, int flags, uchar **packetp)

2.40.1