Tom, Simon,
Can we please handle this series and apply it to master? A lot of Android-related patches depend on this, so if all comments are addressed in v4 and there are no further concerns, it would be great to have it merged ASAP so we can handle more patches while merge window is still open.
Thanks!
On Sun, Jul 7, 2019 at 4:34 PM Eugeniu Rosca roscaeugeniu@gmail.com wrote:
The first patch does the necessary fixing and polishing of include/android_bootloader_message.h and is a hard prerequisite for this series.
The second patch performs the implementation of the 'bcb' command. The third patch relocates the Android README to doc/android. The fourth patch describes the motivation and foreseeable use-cases behind the 'bcb' command in the newly created doc/android/bcb.txt.
v4:
- [Simon Glass] Non-functional refinements in cmd/bcb.c
- [Sam Protsenko] Fix stale references of Android docs
- Place detailed stats in each patch. Full v3 to v4 series interdiff: https://pastebin.ubuntu.com/p/zD66FwBznt/
- Retest on Renesas R-Car H3-ES20 ULCB-KF-M06 using U-Boot v2019.07-rc4-358-g1f83431f0053 as base
v3:
- [Simon Glass] Lots of review comments handled in cmd/bcb.c.
- [Simon Glass, Sam Protsenko] Renamed and enriched android docs.
- Placed detailed stats in each patch.
- https://patchwork.ozlabs.org/cover/1104242/
v2:
- [Heinrich Schuchardt] Implement sub-commands via U_BOOT_CMD_MKENT.
- Polished the code. Ensured no warnings returned by sparse, smatch, `cppcheck --force --enable=all --inconclusive`, make W=1.
- Tested on R-Car-H3-ES20 ULCB-KF.
- https://patchwork.ozlabs.org/cover/1101106/
v1:
Eugeniu Rosca (4): include: android_bootloader_message.h: Minimize the diff to AOSP cmd: Add 'bcb' command to read/modify/write BCB fields doc: android: relocate/rename README files doc: android: add BCB overview and usage
cmd/Kconfig | 19 +- cmd/Makefile | 1 + cmd/bcb.c | 338 ++++++++++++++++++ doc/{README.avb2 => android/avb2.txt} | 0 doc/android/bcb.txt | 89 +++++ .../fastboot-protocol.txt} | 0 .../fastboot.txt} | 2 +- include/android_bootloader_message.h | 126 ++++--- test/py/tests/test_avb.py | 2 +- 9 files changed, 516 insertions(+), 61 deletions(-) create mode 100644 cmd/bcb.c rename doc/{README.avb2 => android/avb2.txt} (100%) create mode 100644 doc/android/bcb.txt rename doc/{README.android-fastboot-protocol => android/fastboot-protocol.txt} (100%) rename doc/{README.android-fastboot => android/fastboot.txt} (98%)
-- 2.22.0