6 Jul
2008
6 Jul
'08
10:50 p.m.
In message 1214491834-27033-1-git-send-email-daveliu@freescale.com you wrote:
Current fat.c have three 64KB static array, it makes the BSS section larger. Change the static to dynamic allocation.
So what's the benefit? BSS size doesn't matter - itr comes for free. It get's initialized automatically.
You add more than 30 lines of code instead, plus a lot of string space, plus a new failure mode (malloc failed) that didn't exist before.
Looks like a pessimizing patch to me, but maybe you just did not describe which problem you are trying to fix?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Remember, there's a big difference between kneeling down and bending
over. - Frank Zappa