29 Oct
2008
29 Oct
'08
1:20 p.m.
Dear "Bigler, Stefan",
In message D839955AA28B9A42A61B9181506E27C4012E1907@SRVCHBER1212.ch.keymile.net you wrote:
Here is patch for the driver for MPC8xx (SMC). If the idea is accepted the then the driver for MPC82xx will be enhanced as well.
Your patch was line wrapped by your mailed and thus corrupted.
Also, it has a many coding style issues (indentation not by TAB, MixedCaseVariableNamesWhichAreNotAllowedInUBootBecauseTheyAreHardToRead, too many empty lines, incorrect multi-line comment format, too long lines, incorrect brace style, trailing white space, etc.).
But please see my previous message - I don't think it is necessary to fix and resubmit the patch.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Doubt isn't the opposite of faith; it is an element of faith.
- Paul Tillich, German theologian and historian